Comments on: Min-Heap in Python

By: joern

joern — Mon, 11 Jul 2011 06:16:22 +0000

seriously? NO!

If you do it like that, you just iterate over the list backend of the heap which will not be sorted correctly!

By: joern

joern — Mon, 11 Jul 2011 06:12:40 +0000

Which python version do you use and how did you input my code sample? There seems to be a white-space problem with empty lines in WordPress and the code highlighting plugin I use, so maybe the whole problem is that your class definition wasn’t complete? (Should’ve given a syntax error though.)

I tested the code on py2.6 and 2.7, don’t know about 3.x yet.

By: John Miller

John Miller — Mon, 11 Jul 2011 02:51:00 +0000

Found your problem:

def __iter__(self):
“”" Get all elements ordered by asc. priority. “”"
return iter(self._heap)

By: John Miller

John Miller — Mon, 11 Jul 2011 02:39:36 +0000

When I try running your code, this is the error I get:

“TypeError: iter() returned non-iterator of type ‘Heap’”

How can I correct this?